Messages in this thread | | | Date | Mon, 4 Mar 2019 11:24:24 +0100 | From | Simon Horman <> | Subject | Re: [PATCH 08/15] ARM: shmobile: fix a leaked reference by addingmissing of_node_put |
| |
On Fri, Mar 01, 2019 at 10:51:27AM +0100, Geert Uytterhoeven wrote: > On Fri, Mar 1, 2019 at 9:57 AM Wen Yang <wen.yang99@zte.com.cn> wrote: > > The call to of_get_next_child returns a node pointer with refcount > > incremented thus it must be explicitly decremented after the last > > usage. > > > > Detected by coccinelle with the following warnings: > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:77:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:85:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > ./arch/arm/mach-shmobile/pm-rcar-gen2.c:90:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 66, but without a corresponding object release within this function. > > > > Signed-off-by: Wen Yang <wen.yang99@zte.com.cn> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Thanks, applied for v5.2.
| |