Messages in this thread | | | Date | Mon, 4 Mar 2019 11:17:36 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v4 01/17] x86/common: Align cpu_caps_cleared and cpu_caps_set to unsigned long |
| |
On Mon, Mar 04, 2019 at 09:33:16AM +0100, Paolo Bonzini wrote: > Why not instead change set_bit/clear_bit to use btsl/btrl instead of > btsq/btrq?
At least one of the faulty users (wireless) is in generic code and needs fixing regardless.
For better or worse; the bitmap stuff is defined to work on unsigned long. Using it on smaller types already relies on small endian; but further enabling just makes it worse I feel. Better have the rules be uniform.
| |