lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 0/2] x86/mm/KASLR: Change the granularity of randomization to PUD size in 5-level
On 03/04/19 at 11:15am, Kirill A. Shutemov wrote:
> On Fri, Mar 01, 2019 at 10:45:02PM +0800, Baoquan He wrote:
> > Hi Kirill,
> >
> > I updated patch per your comments. While I kept the 'paddr' variable and
> > the '0' initilization stuffs. My thought is there are two kinds of mapping
> > in the handling, so keeping these names from old codes can make it more
> > understandable. What do you think?
> >
> > Kind Physical address Virtual address
> > ----------------------------------------------------------------
> > Direct mapping paddr vaddr = paddr+PAGE_OFFSET
> > 1:1 mapping paddr paddr
>
> I agree with your logic and patch looks good to me. But maybe you should
> exmplain this in the comments too?

OK, will add this into code comment, and sent a v3 patchset to wrap all
these changes according to your suggestions. Thanks a lot.

Thanks
Baoquan

\
 
 \ /
  Last update: 2019-03-04 09:53    [W:2.357 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site