lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 69/78] mmc: cqhci: fix space allocated for transfer descriptor
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alamy Liu <alamy.liu@gmail.com>

    commit 27ec9dc17c48ea2e642ccb90b4ebf7fd47468911 upstream.

    There is not enough space being allocated when DCMD is disabled.

    CQE_DCMD is not necessary to be enabled when CQE is enabled.
    (Software could halt CQE to send command)

    In the case that CQE_DCMD is not enabled, it still needs to allocate
    space for data transfer. For instance:
    CQE_DCMD is enabled: 31 slots space (one slot used by DCMD)
    CQE_DCMD is disabled: 32 slots space

    Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
    Signed-off-by: Alamy Liu <alamy.liu@gmail.com>
    Acked-by: Adrian Hunter <adrian.hunter@intel.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/mmc/host/cqhci.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/mmc/host/cqhci.c
    +++ b/drivers/mmc/host/cqhci.c
    @@ -201,7 +201,7 @@ static int cqhci_host_alloc_tdl(struct c
    cq_host->desc_size = cq_host->slot_sz * cq_host->num_slots;

    cq_host->data_size = cq_host->trans_desc_len * cq_host->mmc->max_segs *
    - (cq_host->num_slots - 1);
    + cq_host->mmc->cqe_qdepth;

    pr_debug("%s: cqhci: desc_size: %zu data_sz: %zu slot-sz: %d\n",
    mmc_hostname(cq_host->mmc), cq_host->desc_size, cq_host->data_size,

    \
     
     \ /
      Last update: 2019-03-04 09:31    [W:4.051 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site