lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] watchdog: orion_wdt: use timer1 as a pretimeout
> > Hi Chris
> >
> > I had a quick look at other drivers implementing pre-timeout. They
> > seem to call watchdog_notify_pretimeout(). I don't see that here? What
> > happens when timer1 fires?
> >
>
> It invokes the regular orion_wdt_irq(). On Armada-385 prior to this
> change the irq was not specified because the reset always kicked in so
> there was no point.
>
> For correctness I could make the devicetree binding specify 2
> interrupts. One for the regular watchdog interrupt (which would never
> usually get hit because the reset would kick in) and one for the
> pretimeout/timer1.

Hi Chris

If the regular watchdog interrupt would never actually fire because
the SoC gets reset, maybe make the IRQ handler call
watchdog_notify_pretimeout()?

Andrew

\
 
 \ /
  Last update: 2019-03-05 03:11    [W:0.108 / U:1.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site