lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH net] net: hns3: add rmb() for rx description
From
Date


On 2019/3/4 13:15, David Miller wrote:
> From: Huazhong Tan <tanhuazhong@huawei.com>
> Date: Sat, 2 Mar 2019 16:49:30 +0800
>
>> From: Jian Shen <shenjian15@huawei.com>
>>
>> HW can not guarantee complete write desc->rx.size, even though
>> HNS3_RXD_VLD_B has been set. Driver needs to add rmb() instruction
>> to make sure desc->rx.size is always valid.
>>
>> Fixes: e55970950556 ("net: hns3: Add handling of GRO Pkts not fully RX'ed in NAPI poll")
>> Signed-off-by: Jian Shen <shenjian15@huawei.com>
>> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>
> dma_rmb() is more appropriate here and more efficient.
>

Thanks, will send V2 to fix it.

> .
>

\
 
 \ /
  Last update: 2019-03-05 02:04    [W:0.176 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site