lkml.org 
[lkml]   [2019]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] drivers: x86: pcengines-apuv2: fix dependencies
From
Date
On 3/4/19 4:24 PM, Enrico Weigelt, metux IT consult wrote:
> pcengines-apuv2 board driver needs to explicitly select LEDS_CLASS,
> INPUT, INPUT_KEYBOARD, so these are automatically defined correctly
> (eg. LEDS_CLASS=y if PCENGINES_APU2=y)
>
> Cc: linux-gpio@vger.kernel.org
> Cc: linus.walleij@linaro.org
> Cc: andy.shevchenko@gmail.com
> Cc: arnd@arndb.de
> Cc: rdunlap@infradead.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Reported-by: arnd@arndb.de
> Reported-by: rdunlap@infradead.org
> Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net>
> ---
> drivers/platform/x86/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 851ea92..7d53380 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -1307,7 +1307,10 @@ config PCENGINES_APU2
> tristate "PC Engines APUv2/3 front button and LEDs driver"
> select GPIO_AMD_FCH
> select KEYBOARD_GPIO_POLLED
> + select LEDS_CLASS
> select LEDS_GPIO
> + select INPUT

Nak. We don't select entire subsystems. You should do:

depends on INPUT
select INPUT_KEYBOARD

> + select INPUT_KEYBOARD


> help
> This driver provides support for the front button and LEDs on
> PC Engines APUv2/APUv3 board.
>


--
~Randy

\
 
 \ /
  Last update: 2019-03-05 01:34    [W:0.031 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site