lkml.org 
[lkml]   [2019]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[BUG/PATCH 2/4] REVERT: DTS: GTA04: SPI / gpiolib: no no no, we do not want to "fix" our device tree file
    Date
    just because some legacy boards seem to require changes in the gpio-lib
    which make our so far correct DTS/DTB being wrongly interpreted.

    A better solution seems to make the legacy handler optional so that DTS/DTB
    developed without legacy modes are not harmed.

    Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
    ---
    arch/arm/boot/dts/omap3-gta04.dtsi | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
    index 1e134dfab428..04f2b53d4d3d 100644
    --- a/arch/arm/boot/dts/omap3-gta04.dtsi
    +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
    @@ -114,7 +114,6 @@
    gpio-miso = <&gpio1 18 GPIO_ACTIVE_HIGH>;
    gpio-mosi = <&gpio1 20 GPIO_ACTIVE_HIGH>;
    cs-gpios = <&gpio1 19 GPIO_ACTIVE_HIGH>;
    - spi-cs-high; /* make the legacy handler in gpiolib not intervene */
    num-chipselects = <1>;

    /* lcd panel */
    @@ -124,7 +123,6 @@
    spi-max-frequency = <100000>;
    spi-cpol;
    spi-cpha;
    - spi-cs-high; /* here is where it should be but this is ignored by a bug in the gpiolib handler */

    backlight= <&backlight>;
    label = "lcd";
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-31 12:09    [W:5.298 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site