lkml.org 
[lkml]   [2019]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] x86/traps: print faulty addresses on stack overflow
Date
Since commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"),
when a stack overflow happens "____ptrval____" is printed instead of the
real addresses:

BUG: stack guard page was hit at (____ptrval____) (stack is (____ptrval____)..(____ptrval____))

Even if leaking kernel layout information is usually a bad thing, probably
the system needs to be rebooted anyway past this point, so force the
address print as the obfuscation makes the error message useless.

Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
arch/x86/kernel/traps.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/kernel/traps.c b/arch/x86/kernel/traps.c
index d26f9e9c3d83..0d3695334dfd 100644
--- a/arch/x86/kernel/traps.c
+++ b/arch/x86/kernel/traps.c
@@ -301,7 +301,7 @@ __visible void __noreturn handle_stack_overflow(const char *message,
struct pt_regs *regs,
unsigned long fault_address)
{
- printk(KERN_EMERG "BUG: stack guard page was hit at %p (stack is %p..%p)\n",
+ printk(KERN_EMERG "BUG: stack guard page was hit at %px (stack is %px..%px)\n",
(void *)fault_address, current->stack,
(char *)current->stack + THREAD_SIZE - 1);
die(message, regs, 0);
--
2.20.1
\
 
 \ /
  Last update: 2019-04-01 02:04    [W:0.031 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site