lkml.org 
[lkml]   [2019]   [Mar]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] KVM: arm/arm64: arch_timer: Fix TimerValue TVAL calculation in KVM
On Fri, 29 Mar 2019 20:12:53 +0000,
Wei Huang <wei@redhat.com> wrote:
>
> Recently the generic timer test of kvm-unit-tests failed to complete
> (stalled) when a physical timer is being used. This issue is caused
> by incorrect update of CNT_CVAL when TimerValue is being accessed,
> introduced by 'Commit 84135d3d18da ("KVM: arm/arm64: consolidate arch
> timer trap handlers")'. According to Arm ARM, the read/write behavior
> of accesses to TimeValue registers is expected to be:
>
> * READ: TimerValue = (CompareValue – (Counter - Offset)
> * WRITE: CompareValue = ((Counter - Offset) + Sign(TimerValue)
>
> This patch fixes the TVAL read/write code path according to the
> specification.
>
> Signed-off-by: Wei Huang <wei@redhat.com>

Huh... Nice catch. I guess I only ran this with a VHE host, where this
code path is unused.

Thanks,

M.

--
Jazz is not dead, it just smell funny.

\
 
 \ /
  Last update: 2019-03-30 10:57    [W:0.029 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site