Messages in this thread | | | From | Roopa Prabhu <> | Date | Sat, 30 Mar 2019 06:50:38 -0700 | Subject | Re: [PATCH] trace: events: fix error directive in argument list |
| |
On Sat, Mar 30, 2019 at 5:40 AM Steven Rostedt <rostedt@goodmis.org> wrote: > > On Sat, 30 Mar 2019 13:01:41 +0100 > Luc Van Oostenryck <luc.vanoostenryck@gmail.com> wrote: > > > OK, I see. IMO, it would be better to have 2 patches for this: > > one for the redundant assignment to pin6 and anotther one for > > the IS_ENABLED() change but feel free, if needed, to add my > > I agree with it being separate patches. I'm big on the "one patch > accomplishes one task" ideology. >
yes, I will take care of the pin6 assignment separately. This patch can only address the sparse error.
| |