Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 30 Mar 2019 21:14:07 +0900 | Subject | Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary |
| |
On Sat, Mar 23, 2019 at 10:55 AM Douglas Anderson <dianders@chromium.org> wrote: > > If you drop into kdb and type "summary", it prints out a line that > says this: > > ccversion CCVERSION > > ...and I don't mean that it actually prints out the version of the C > compiler. It literally prints out the string "CCVERSION". > > The version of the C Compiler is already printed at boot up and it > doesn't seem useful to replicate this in kdb. Let's just delete it. > We can also delete the bit of the Makefile that called the C compiler > in an attempt to pass this into kdb. This will remove one extra call > to the C compiler at Makefile parse time and (very slightly) speed up > builds. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > ---
Reviewed-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> kernel/debug/kdb/Makefile | 1 - > kernel/debug/kdb/kdb_main.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/kernel/debug/kdb/Makefile b/kernel/debug/kdb/Makefile > index d4fc58f4b88d..efac857c5511 100644 > --- a/kernel/debug/kdb/Makefile > +++ b/kernel/debug/kdb/Makefile > @@ -6,7 +6,6 @@ > # Copyright (c) 2009 Wind River Systems, Inc. All Rights Reserved. > # > > -CCVERSION := $(shell $(CC) -v 2>&1 | sed -ne '$$p') > obj-y := kdb_io.o kdb_main.o kdb_support.o kdb_bt.o gen-kdb_cmds.o kdb_bp.o kdb_debugger.o > obj-$(CONFIG_KDB_KEYBOARD) += kdb_keyboard.o > > diff --git a/kernel/debug/kdb/kdb_main.c b/kernel/debug/kdb/kdb_main.c > index 82a3b32a7cfc..fc96dbf8d9de 100644 > --- a/kernel/debug/kdb/kdb_main.c > +++ b/kernel/debug/kdb/kdb_main.c > @@ -2522,7 +2522,6 @@ static int kdb_summary(int argc, const char **argv) > kdb_printf("machine %s\n", init_uts_ns.name.machine); > kdb_printf("nodename %s\n", init_uts_ns.name.nodename); > kdb_printf("domainname %s\n", init_uts_ns.name.domainname); > - kdb_printf("ccversion %s\n", __stringify(CCVERSION)); > > now = __ktime_get_real_seconds(); > time64_to_tm(now, 0, &tm); > -- > 2.21.0.392.gf8f6787159e-goog >
-- Best Regards Masahiro Yamada
| |