lkml.org 
[lkml]   [2019]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 21/52] thermal/int340x_thermal: fix mode setting
    Date
    From: Matthew Garrett <matthewgarrett@google.com>

    [ Upstream commit 396ee4d0cd52c13b3f6421b8d324d65da5e7e409 ]

    int3400 only pushes the UUID into the firmware when the mode is flipped
    to "enable". The current code only exposes the mode flag if the firmware
    supports the PASSIVE_1 UUID, which not all machines do. Remove the
    restriction.

    Signed-off-by: Matthew Garrett <mjg59@google.com>
    Signed-off-by: Zhang Rui <rui.zhang@intel.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/thermal/int340x_thermal/int3400_thermal.c | 7 +++----
    1 file changed, 3 insertions(+), 4 deletions(-)

    diff --git a/drivers/thermal/int340x_thermal/int3400_thermal.c b/drivers/thermal/int340x_thermal/int3400_thermal.c
    index 51c9097eaf7a..e9d58de8b5da 100644
    --- a/drivers/thermal/int340x_thermal/int3400_thermal.c
    +++ b/drivers/thermal/int340x_thermal/int3400_thermal.c
    @@ -316,10 +316,9 @@ static int int3400_thermal_probe(struct platform_device *pdev)

    platform_set_drvdata(pdev, priv);

    - if (priv->uuid_bitmap & 1 << INT3400_THERMAL_PASSIVE_1) {
    - int3400_thermal_ops.get_mode = int3400_thermal_get_mode;
    - int3400_thermal_ops.set_mode = int3400_thermal_set_mode;
    - }
    + int3400_thermal_ops.get_mode = int3400_thermal_get_mode;
    + int3400_thermal_ops.set_mode = int3400_thermal_set_mode;
    +
    priv->thermal = thermal_zone_device_register("INT3400 Thermal", 0, 0,
    priv, &int3400_thermal_ops,
    &int3400_thermal_params, 0, 0);
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-30 02:07    [W:3.627 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site