lkml.org 
[lkml]   [2019]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.14 07/37] ALSA: sb8: add a check for request_region
    Date
    From: Kangjie Lu <kjlu@umn.edu>

    [ Upstream commit dcd0feac9bab901d5739de51b3f69840851f8919 ]

    In case request_region fails, the fix returns an error code to
    avoid NULL pointer dereference.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/isa/sb/sb8.c | 4 ++++
    1 file changed, 4 insertions(+)

    diff --git a/sound/isa/sb/sb8.c b/sound/isa/sb/sb8.c
    index d77dcba276b5..1eb8b61a185b 100644
    --- a/sound/isa/sb/sb8.c
    +++ b/sound/isa/sb/sb8.c
    @@ -111,6 +111,10 @@ static int snd_sb8_probe(struct device *pdev, unsigned int dev)

    /* block the 0x388 port to avoid PnP conflicts */
    acard->fm_res = request_region(0x388, 4, "SoundBlaster FM");
    + if (!acard->fm_res) {
    + err = -EBUSY;
    + goto _err;
    + }

    if (port[dev] != SNDRV_AUTO_PORT) {
    if ((err = snd_sbdsp_create(card, port[dev], irq[dev],
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-30 02:05    [W:5.123 / U:0.104 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site