Messages in this thread | | | Date | Thu, 28 Mar 2019 16:20:01 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/7] x86/boot: Introduce helpers for serial I/O |
| |
On Thu, Mar 28, 2019 at 03:05:08PM +0100, Borislav Petkov wrote: > On Thu, Mar 28, 2019 at 03:52:26PM +0200, Andy Shevchenko wrote: > > It's not a generic serial_in()... > > Why?
By name and by what it's handling (only byte accesses to I/O or MMIO).
> > What about mmio32 as next step? > > Next step where? Is it part of your patches?
Not this series, but we have hardware that does MMIO32 accesses and yet using non-standard address.
My point is, that doing branch(es) on each I/O call is not good as simple calling the proper (pre-defined) I/O accessor.
-- With Best Regards, Andy Shevchenko
| |