Messages in this thread | | | Date | Thu, 28 Mar 2019 11:09:38 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 1/7] x86/boot: Convert early_serial_base to unsigned long |
| |
On Thu, Mar 28, 2019 at 09:28:23AM +0100, Borislav Petkov wrote: > On Tue, Mar 19, 2019 at 09:43:19PM +0300, Andy Shevchenko wrote: > > As a preparatory of adding flexible serial I/O accessors, convert > > early_serial_base to unsigned long to cover all possible bus addresses > > on the system.
> > @@ -48,7 +48,7 @@ static void parse_earlyprintk(void) > > int baud = DEFAULT_BAUD; > > char arg[32]; > > int pos = 0; > > - int port = 0; > > + unsigned long port = 0; > > > > if (cmdline_find_option("earlyprintk", arg, sizeof(arg)) > 0) { > > char *e; > > @@ -118,7 +118,7 @@ static void parse_console_uart8250(void) > > { > > char optstr[64], *options; > > int baud = DEFAULT_BAUD; > > - int port = 0; > > + unsigned long port = 0; > > Here and above:
Agree on above and will fix, but don't see how this different in the latter?
> > Please sort function local variables declaration in a reverse christmas > tree order: > > <type A> longest_variable_name; > <type B> shorter_var_name; > <type C> even_shorter; > <type D> i; >
-- With Best Regards, Andy Shevchenko
| |