lkml.org 
[lkml]   [2019]   [Mar]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v5 05/22] ethtool: introduce ethtool netlink interface
    Thu, Mar 28, 2019 at 03:05:14AM CET, f.fainelli@gmail.com wrote:
    >
    >
    >On 3/27/2019 2:50 AM, Jiri Pirko wrote:
    >>
    >> Why don't you have ETHTOOL_MSG_SET_FOO for set? I think that for
    >> kerne->userspace the ETHTOOL_MSG_FOO if fine. I would change the
    >> ordering of words thought, but it is cosmetics:
    >> ETHTOOL_MSG_FOO /* kernel->userspace messages - replies, notifications */
    >> ETHTOOL_MSG_FOO_GET
    >> ETHTOOL_MSG_FOO_SET
    >> ETHTOOL_MSG_FOO_ACT
    >>
    >> What do you think?
    >
    >We could even name the notification explicitly with: ETHTOOL_MSG_NOTIF
    >or ETHTOOL_MSG_NTF just so we spell out exactly what those messages are.

    Sound good. Something like:

    ETHTOOL_MSG_FOO_GET
    ETHTOOL_MSG_FOO_GET_RPLY /* kernel->userspace replies to get */
    ETHTOOL_MSG_FOO_SET
    ETHTOOL_MSG_FOO_ACT
    ETHTOOL_MSG_FOO_NTF /* kernel->userspace async messages - notifications */

    \
     
     \ /
      Last update: 2019-03-28 09:12    [W:4.712 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site