Messages in this thread | | | Subject | Re: [PATCH] media: vpss: fix a potential NULL pointer dereference | From | Mukesh Ojha <> | Date | Wed, 27 Mar 2019 18:28:17 +0530 |
| |
On 3/23/2019 8:21 AM, Kangjie Lu wrote: > In case ioremap fails, the fix returns -ENOMEM to avoid NULL > pointer dereference. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
-Mukesh
> --- > drivers/media/platform/davinci/vpss.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c > index 19cf6853411e..89a86c19579b 100644 > --- a/drivers/media/platform/davinci/vpss.c > +++ b/drivers/media/platform/davinci/vpss.c > @@ -518,6 +518,11 @@ static int __init vpss_init(void) > return -EBUSY; > > oper_cfg.vpss_regs_base2 = ioremap(VPSS_CLK_CTRL, 4); > + if (unlikely(!oper_cfg.vpss_regs_base2)) { > + release_mem_region(VPSS_CLK_CTRL, 4); > + return -ENOMEM; > + } > + > writel(VPSS_CLK_CTRL_VENCCLKEN | > VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2); >
| |