Messages in this thread | | | Date | Wed, 27 Mar 2019 09:47:51 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH] vhost: zero vhost_vsock memory on allocation |
| |
On Tue 26-03-19 20:56:14, Vitaly Mayatskikh wrote: > This fixes OOPS when using under-initialized vhost_vsock object. > > The code had a combo of kzalloc plus vmalloc as a fallback > initially, but it has been replaced by plain kvmalloc in > commit 6c5ab6511f71 ("mm: support __GFP_REPEAT in kvmalloc_node for >32kB") > > OOPS is easy to reproduce with open/ioctl after trashing the RAM.
Sorry for the screw up, that was certainly not inteded effect of the patch.
Fixes: 6c5ab6511f71 ("mm: support __GFP_REPEAT in kvmalloc_node for >32kB") Cc: stable # 4.12+
> Signed-off-by: Vitaly Mayatskikh <v.mayatskih@gmail.com>
Acked-by: Michal Hocko <mhocko@suse.com>
Thanks for catching that.
> --- > drivers/vhost/vsock.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/vhost/vsock.c b/drivers/vhost/vsock.c > index bb5fc0e..9e7cb13 100644 > --- a/drivers/vhost/vsock.c > +++ b/drivers/vhost/vsock.c > @@ -512,7 +512,7 @@ static int vhost_vsock_dev_open(struct inode *inode, struct file *file) > /* This struct is large and allocation could fail, fall back to vmalloc > * if there is no other way. > */ > - vsock = kvmalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL); > + vsock = kvzalloc(sizeof(*vsock), GFP_KERNEL | __GFP_RETRY_MAYFAIL); > if (!vsock) > return -ENOMEM; > > -- > 1.8.3.1 >
-- Michal Hocko SUSE Labs
| |