| Subject | Re: [PATCH net-next v5 19/22] ethtool: provide WoL information in GET_SETTINGS request | From | Florian Fainelli <> | Date | Wed, 27 Mar 2019 20:42:26 -0700 |
| |
On 3/25/2019 10:08 AM, Michal Kubecek wrote: > Add information about supported and enabled wake on LAN modes into the > GET_SETTINGS reply when ETH_SETTINGS_IM_WOL flag is set in the request. > > The GET_SETTINGS request can be still sent by unprivileged users but in > such case the SecureOn password (if any) is not included in the reply. > > Send notification in the same format as reply SET_SETTINGS message when > wake on LAN settings are modified using ioctl interface (ETHTOOL_SWOL > command).
Looks good to me, just one question below:
> > Signed-off-by: Michal Kubecek <mkubecek@suse.cz> > ---
[snip] > > + data->privileged = ethnl_is_privileged(skb);
Is not this potentially creating a time of check/time of use issue? Can you check for ethnl_is_privileged() at the time where you fill in the reply skb? -- Florian
|