Messages in this thread | | | Date | Wed, 27 Mar 2019 13:44:54 -0700 (PDT) | Subject | Re: net: fix routing encapsulated packets when binding a socket to a tunnel interface | From | David Miller <> |
| |
From: lifonghsu <lifonghsu@synology.com> Date: Fri, 22 Mar 2019 14:29:58 +0800
> From: LiFong Hsu <lifonghsu@synology.com> > > When binding a socket to a 4in6/6in4 tunnel interface, the kernel sends > the packet to the tunnel interface without any problem, e.g., > ping 8.8.8.8 -I 4in6. However, after the 4in6/6in4 tunnel encapsulation, > the encapsulated packet could be sent to the tunnel interface again when > some fields of the skb were changed in mangle table's output chain, > such as skb->mark and src/dest IP address. Sending to the tunnel interface > twice is unexpected, since there are no corresponding routing rules on > the tunnel interface for the encapsulated packet. Eventually, the encapsulated > packet will be dropped by the tunnel interface. > > This commit stops referring to sk_bound_dev_if while re-routing a packet > with skb_iif!=0 which indicates that the packet has already been sent to > the interface specified by sk_bound_dev_if. Instead, this commit sends > the packet to the underlying network device. > > Signed-off-by: LiFong Hsu <lifonghsu@synology.com> > Reviewed-by: JianJhen Chen <kchen@synology.com>
If you do not respond to my feedback, I am going to drop your patch.
You have 24 hours to respond before that happens.
| |