lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 09/10] iommu/vt-d: Flush IOTLB for untrusted device in time
    Date
    By default, for performance consideration, Intel IOMMU
    driver won't flush IOTLB immediately after a buffer is
    unmapped. It schedules a thread and flushes IOTLB in a
    batched mode. This isn't suitable for untrusted device
    since it still can access the memory even if it isn't
    supposed to do so.

    Cc: Ashok Raj <ashok.raj@intel.com>
    Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
    Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
    Tested-by: Xu Pengfei <pengfei.xu@intel.com>
    Tested-by: Mika Westerberg <mika.westerberg@intel.com>
    ---
    drivers/iommu/intel-iommu.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c
    index b9f57ecd01b4..4ad8ac7f791e 100644
    --- a/drivers/iommu/intel-iommu.c
    +++ b/drivers/iommu/intel-iommu.c
    @@ -3745,10 +3745,14 @@ static void intel_unmap(struct device *dev, dma_addr_t dev_addr, size_t size)
    unsigned long iova_pfn;
    struct intel_iommu *iommu;
    struct page *freelist;
    + struct pci_dev *pdev = NULL;

    if (iommu_no_mapping(dev))
    return;

    + if (dev_is_pci(dev))
    + pdev = to_pci_dev(dev);
    +
    domain = find_domain(dev);
    BUG_ON(!domain);

    @@ -3764,7 +3768,7 @@ static void intel_unmap(struct device *dev, dma_addr_t dev_addr, size_t size)

    freelist = domain_unmap(domain, start_pfn, last_pfn);

    - if (intel_iommu_strict) {
    + if (intel_iommu_strict || (pdev && pdev->untrusted)) {
    iommu_flush_iotlb_psi(iommu, domain, start_pfn,
    nrpages, !freelist, 0);
    /* free iova */
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-03-27 07:42    [W:3.090 / U:0.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site