lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.0 149/262] selftests: skip seccomp get_metadata test if not real root
    Date
    From: Tycho Andersen <tycho@tycho.ws>

    [ Upstream commit 3aa415dd2128e478ea3225b59308766de0e94d6b ]

    The get_metadata() test requires real root, so let's skip it if we're not
    real root.

    Note that I used XFAIL here because that's what the test does later if
    CONFIG_CHEKCKPOINT_RESTORE happens to not be enabled. After looking at the
    code, there doesn't seem to be a nice way to skip tests defined as TEST(),
    since there's no return code (I tried exit(KSFT_SKIP), but that didn't work
    either...). So let's do it this way to be consistent, and easier to fix
    when someone comes along and fixes it.

    Signed-off-by: Tycho Andersen <tycho@tycho.ws>
    Acked-by: Kees Cook <keescook@chromium.org>
    Signed-off-by: Shuah Khan <shuah@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    tools/testing/selftests/seccomp/seccomp_bpf.c | 6 ++++++
    1 file changed, 6 insertions(+)

    diff --git a/tools/testing/selftests/seccomp/seccomp_bpf.c b/tools/testing/selftests/seccomp/seccomp_bpf.c
    index 7e632b465ab4..6d7a81306f8a 100644
    --- a/tools/testing/selftests/seccomp/seccomp_bpf.c
    +++ b/tools/testing/selftests/seccomp/seccomp_bpf.c
    @@ -2971,6 +2971,12 @@ TEST(get_metadata)
    struct seccomp_metadata md;
    long ret;

    + /* Only real root can get metadata. */
    + if (geteuid()) {
    + XFAIL(return, "get_metadata requires real root");
    + return;
    + }
    +
    ASSERT_EQ(0, pipe(pipefd));

    pid = fork();
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-27 20:24    [W:3.945 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site