lkml.org 
[lkml]   [2019]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 4.19 011/192] include/linux/relay.h: fix percpu annotation in struct rchan
    Date
    From: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>

    [ Upstream commit 62461ac2e5b6520b6d65fc6d7d7b4b8df4b848d8 ]

    The percpu member of this structure is declared as:
    struct ... ** __percpu member;
    So its type is:
    __percpu pointer to pointer to struct ...

    But looking at how it's used, its type should be:
    pointer to __percpu pointer to struct ...
    and it should thus be declared as:
    struct ... * __percpu *member;

    So fix the placement of '__percpu' in the definition of this
    structures.

    This silents a few Sparse's warnings like:
    warning: incorrect type in initializer (different address spaces)
    expected void const [noderef] <asn:3> *__vpp_verify
    got struct sched_domain **

    Link: http://lkml.kernel.org/r/20190118144902.79065-1-luc.vanoostenryck@gmail.com
    Fixes: 017c59c042d01 ("relay: Use per CPU constructs for the relay channel buffer pointers")
    Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
    Cc: Jens Axboe <axboe@suse.de>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
    Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    include/linux/relay.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/include/linux/relay.h b/include/linux/relay.h
    index e1bdf01a86e2..c759f96e39c1 100644
    --- a/include/linux/relay.h
    +++ b/include/linux/relay.h
    @@ -66,7 +66,7 @@ struct rchan
    struct kref kref; /* channel refcount */
    void *private_data; /* for user-defined data */
    size_t last_toobig; /* tried to log event > subbuf size */
    - struct rchan_buf ** __percpu buf; /* per-cpu channel buffers */
    + struct rchan_buf * __percpu *buf; /* per-cpu channel buffers */
    int is_global; /* One global buffer ? */
    struct list_head list; /* for channel list */
    struct dentry *parent; /* parent dentry passed to open */
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-03-27 20:12    [W:4.094 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site