lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/5] ARM: dts: imx50: Add Kobo Aura DTS
Hi, thanks for your comments. I'll address them in v2.

On Fri, Mar 22, 2019 at 09:31:53AM +0800, Shawn Guo wrote:
> On Tue, Mar 19, 2019 at 04:24:17PM +0100, Jonathan Neuschäfer wrote:
> > The Kobo Aura is an e-book reader released in 2013.
[...]
> > + sd2_pwrseq: pwrseq {
> > + compatible = "mmc-pwrseq-simple";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_sd2_reset>;
> > +
>
> Please do not have random newlines.

Does that apply to all empty lines between properties?

>
> > + reset-gpios = <&gpio4 17 GPIO_ACTIVE_LOW>;
> > + };
> > +
[...]
> > +&iomuxc {
> > + pinctrl_uart2: uart2 {
> > + fsl,pins = <
> > + MX50_PAD_UART2_TXD__UART2_TXD_MUX 0x1e4
> > + MX50_PAD_UART2_RXD__UART2_RXD_MUX 0x1e4
> > + >;
> > + };
> > +
> > + pinctrl_i2c1: i2c1 {
>
> Please sort these pinctrl nodes alphabetically.

It doesn't make a difference here, but should I generally sort by name
or by label in cases like this one?


Jonathan Neuschäfer
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-26 17:28    [W:0.087 / U:0.540 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site