lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/2] dt-bindings: extcon: Add support for fsa9480 switch
    On Mon, Feb 25, 2019 at 05:58:21PM +0100, Paweł Chmiel wrote:
    > From: Tomasz Figa <tomasz.figa@gmail.com>
    >
    > This patch adds documentation for binding of extcont Fairchild
    > Semiconductor FSA9480 microusb switch.
    > This usb port accessory detector and switch, can be found for example in
    > some Samsung s5pv210 based phones.
    >
    > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
    > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>
    > ---
    > .../bindings/extcon/extcon-fsa9480.txt | 21 +++++++++++++++++++
    > 1 file changed, 21 insertions(+)
    > create mode 100644 Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
    >
    > diff --git a/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
    > new file mode 100644
    > index 000000000000..ebced7b18eb5
    > --- /dev/null
    > +++ b/Documentation/devicetree/bindings/extcon/extcon-fsa9480.txt
    > @@ -0,0 +1,21 @@
    > +FAIRCHILD SEMICONDUCTOR FSA9480 MICROUSB SWITCH
    > +
    > +The FSA9480 is a USB port accessory detector and switch. The FSA9480 is fully
    > +controlled using I2C and enables USB data, stereo and mono audio, video,
    > +microphone, and UART data to use a common connector port.
    > +
    > +Required properties:
    > + - compatible : Must be "fcs,fsa9480"
    > + - reg : Specifies i2c slave address. Must be 0x25.
    > + - interrupt-parent : Phandle to interrupt controller to which interrupt
    > + signal of the chip is connected.

    Remove this as it is implicit.

    > + - interrupts : Should contain one entry specifying interrupt signal of
    > + interrupt parent to which interrupt pin of the chip is connected.
    > +
    > + Example:
    > + musb@25 {
    > + compatible = "fcs,fsa9480";
    > + reg = <0x25>;
    > + interrupt-parent = <&gph2>;
    > + interrupts = <7 0>;
    > + };
    > \ No newline at end of file

    Fix this.

    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2019-03-26 15:58    [W:2.692 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site