lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC
    Date
    On Mon, 2019-03-25 at 18:04 +0100, Alexandre Belloni wrote:
    > On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote:
    > > Support RTC block in ROHM bd70528 power management IC. Support
    > > getting and setting the time and date as well as arming an alarm
    > > which can also be used to wake the PMIC from standby state.
    > >
    > > HW supports wake interrupt only for the next 24 hours (sec, minute
    > > and hour information only) so we limit also the alarm interrupt to
    > > this 24 hours for the sake of consistency.
    > >
    > > Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
    >
    > Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
    >
    > > + r->time.hour |= BD70528_MASK_RTC_HOUR_24H;
    > > + r->day |= bin2bcd(t->tm_mday);
    > > + r->week |= bin2bcd(t->tm_wday);
    > > + r->month |= bin2bcd(t->tm_mon + 1);
    > > + r->year = bin2bcd(t->tm_year-100);
    >
    > If you ever have to resend, please add spaces around that -

    Good catch, thanks! I wonder why I didn't get checkpatch warning... I
    should've had one. (I usually do run checkpatch).

    Anyways, I'll add spaces if I need to respin the series.

    Br,
    Matti Vaittinen

    \
     
     \ /
      Last update: 2019-03-26 15:07    [W:4.429 / U:0.188 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site