lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V3 01/23] perf/x86: Support outputting XMM registers
On Tue, 26 Mar 2019, Liang, Kan wrote:
> On 3/25/2019 8:11 PM, Thomas Gleixner wrote:
>
> -#define REG_RESERVED (~((1ULL << PERF_REG_X86_MAX) - 1ULL))
> +#define REG_RESERVED 0

What's the point of having this around?

> int perf_reg_validate(u64 mask)
> {
> if (!mask || mask & REG_RESERVED)
> return -EINVAL;

mask & 0 == 0, right? So which bits are you checking here?

Thanks,

tglx

\
 
 \ /
  Last update: 2019-03-26 14:48    [W:0.096 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site