Messages in this thread | | | Date | Tue, 26 Mar 2019 04:43:58 -0700 | From | Matthew Wilcox <> | Subject | Re: [PATCH v2 4/4] drivers/base/memory.c: Rename the misleading parameter |
| |
On Tue, Mar 26, 2019 at 05:02:27PM +0800, Baoquan He wrote: > The input parameter 'phys_index' of memory_block_action() is actually > the section number, but not the phys_index of memory_block. Fix it.
> static int > -memory_block_action(unsigned long phys_index, unsigned long action, int online_type) > +memory_block_action(unsigned long sec, unsigned long action, int online_type)
'sec' is a bad abbreviation for 'section'. We don't use it anyhere else in the vm.
Looking through include/, I see it used as an abbreviation for second, security, ELF section, and section of a book. Nowhere as a memory block section. Please use an extra four letters for this parameter.
| |