lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] arm/komeda: Compile komeda_debugfs_init() only if CONFIG_DEBUG_FS is enabled
Date
On Mon, Mar 25, 2019 at 05:01:14PM +0000, Liviu Dudau wrote:
> We don't call this function if CONFIG_DEBUG_FS is not defined, but we
> should not be compiling it either, as the declaration of the debugfs
> core functions is not included.
>
> Reported by the kbuild test robot.
>
> Signed-off-by: Liviu Dudau <liviu.dudau@arm.com>

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com>
> ---
> drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> index b420c6205d6bf..24548b87e1827 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c
> @@ -44,6 +44,7 @@ static const struct file_operations komeda_register_fops = {
> .release = single_release,
> };
>
> +#ifdef CONFIG_DEBUG_FS
> static void komeda_debugfs_init(struct komeda_dev *mdev)
> {
> if (!debugfs_initialized())
> @@ -56,6 +57,7 @@ static void komeda_debugfs_init(struct komeda_dev *mdev)
> debugfs_create_file("register", 0444, mdev->debugfs_root,
> mdev, &komeda_register_fops);
> }
> +#endif
>
> static int komeda_parse_pipe_dt(struct komeda_dev *mdev, struct device_node *np)
> {
> --
> 2.21.0

\
 
 \ /
  Last update: 2019-03-26 12:09    [W:0.158 / U:0.096 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site