lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] media: vpss: fix a potential NULL pointer dereference
    Hi Kangjie,

    Thanks for the patch.

    On Sat, Mar 23, 2019 at 2:51 AM Kangjie Lu <kjlu@umn.edu> wrote:
    >
    > In case ioremap fails, the fix returns -ENOMEM to avoid NULL
    > pointer dereference.
    >
    > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    > ---
    > drivers/media/platform/davinci/vpss.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    Acked-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>

    Cheers,
    --Prabhakar Lad

    > diff --git a/drivers/media/platform/davinci/vpss.c b/drivers/media/platform/davinci/vpss.c
    > index 19cf6853411e..89a86c19579b 100644
    > --- a/drivers/media/platform/davinci/vpss.c
    > +++ b/drivers/media/platform/davinci/vpss.c
    > @@ -518,6 +518,11 @@ static int __init vpss_init(void)
    > return -EBUSY;
    >
    > oper_cfg.vpss_regs_base2 = ioremap(VPSS_CLK_CTRL, 4);
    > + if (unlikely(!oper_cfg.vpss_regs_base2)) {
    > + release_mem_region(VPSS_CLK_CTRL, 4);
    > + return -ENOMEM;
    > + }
    > +
    > writel(VPSS_CLK_CTRL_VENCCLKEN |
    > VPSS_CLK_CTRL_DACCLKEN, oper_cfg.vpss_regs_base2);
    >
    > --
    > 2.17.1
    >

    \
     
     \ /
      Last update: 2019-03-26 10:46    [W:4.297 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site