Messages in this thread | | | Subject | Re: [PATCH] arm64: gic-v3: fix unexpected overwrite of spi/ppi/sgi prio | From | Marc Zyngier <> | Date | Tue, 26 Mar 2019 09:18:39 +0000 |
| |
On 26/03/2019 08:16, Wei Li wrote: > The priority config will be restored to the default value in the > notifiers of gic suspend. While the arm64 nmi-like interrupt has been > implemented by using priority since commit bc3c03ccb464 ("arm64: Enable > the support of pseudo-NMIs"), we need to do the save and restore exactly. > > Signed-off-by: Wei Li <liwei391@huawei.com> > --- > drivers/irqchip/irq-gic.c | 22 +++++++++++++++++++--- > 1 file changed, 19 insertions(+), 3 deletions(-)
You're complaining about an alleged bug in the GICv3 driver (which is always possible), and yet you're submitting a change to the GICv{1,2} driver, for which we don't support variable priorities.
How does this fix anything? How have you tested this patch? What is the actual problem you're trying to paper over?
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |