lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 13/41] objtool: Move objtool_file struct off the stack
    Date
    4.14-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Josh Poimboeuf <jpoimboe@redhat.com>

    commit 0c671812f152b628bd87c0af49da032cc2a2c319 upstream.

    Objtool uses over 512k of stack, thanks to the hash table embedded in
    the objtool_file struct. This causes an unnecessarily large stack
    allocation and breaks users with low stack limits.

    Move the struct off the stack.

    Fixes: 042ba73fe7eb ("objtool: Add several performance improvements")
    Reported-by: Vassili Karpov <moosotc@gmail.com>
    Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: stable@vger.kernel.org
    Link: https://lkml.kernel.org/r/df92dcbc4b84b02ffa252f46876df125fb56e2d7.1552954176.git.jpoimboe@redhat.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    tools/objtool/check.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    --- a/tools/objtool/check.c
    +++ b/tools/objtool/check.c
    @@ -2132,9 +2132,10 @@ static void cleanup(struct objtool_file
    elf_close(file->elf);
    }

    +static struct objtool_file file;
    +
    int check(const char *_objname, bool orc)
    {
    - struct objtool_file file;
    int ret, warnings = 0;

    objname = _objname;

    \
     
     \ /
      Last update: 2019-03-26 07:47    [W:4.041 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site