lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 07/52] drm/amdgpu: fix invalid use of change_bit
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christian König <christian.koenig@amd.com>

    commit 72464382fc2d3673eb51f21a57f2c0a320c1552f upstream.

    We only need to clear the bit in a 32bit integer.

    This fixes a crah on ARM64 and PPC64LE caused by
    "drm/amdgpu: update the vm invalidation engine layout V2"

    Signed-off-by: Christian König <christian.koenig@amd.com>
    Acked-by: Alex Deucher <alexander.deucher@amd.com>
    Cc: stable@vger.kernel.org
    Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
    +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c
    @@ -738,7 +738,7 @@ static int gmc_v9_0_allocate_vm_inv_eng(
    }

    ring->vm_inv_eng = inv_eng - 1;
    - change_bit(inv_eng - 1, (unsigned long *)(&vm_inv_engs[vmhub]));
    + vm_inv_engs[vmhub] &= ~(1 << ring->vm_inv_eng);

    dev_info(adev->dev, "ring %s uses VM inv eng %u on hub %u\n",
    ring->name, ring->vm_inv_eng, ring->funcs->vmhub);

    \
     
     \ /
      Last update: 2019-03-26 07:43    [W:2.064 / U:0.408 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site