lkml.org 
[lkml]   [2019]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 32/52] ALSA: ac97: Fix of-node refcount unbalance
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Takashi Iwai <tiwai@suse.de>

    commit 31d2350d602511efc9ef626b848fe521233b0387 upstream.

    ac97_of_get_child_device() take the refcount of the node explicitly
    via of_node_get(), but this leads to an unbalance. The
    for_each_child_of_node() loop itself takes the refcount for each
    iteration node, hence you don't need to take the extra refcount
    again.

    Fixes: 2225a3e6af78 ("ALSA: ac97: add codecs devicetree binding")
    Reviewed-by: Robert Jarzmik <robert.jarzmik@free.fr>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    sound/ac97/bus.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/ac97/bus.c
    +++ b/sound/ac97/bus.c
    @@ -84,7 +84,7 @@ ac97_of_get_child_device(struct ac97_con
    if ((idx != of_property_read_u32(node, "reg", &reg)) ||
    !of_device_is_compatible(node, compat))
    continue;
    - return of_node_get(node);
    + return node;
    }

    return NULL;

    \
     
     \ /
      Last update: 2019-03-26 07:43    [W:3.101 / U:0.068 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site