Messages in this thread | | | Date | Tue, 26 Mar 2019 22:20:41 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH v2 09/14] watchdog/hardlockup: Make arch_touch_nmi_watchdog() to hpet-based implementation |
| |
On Thu, 28 Feb 2019, Ricardo Neri wrote: > > > > > > -#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) > > > +#if defined(CONFIG_HARDLOCKUP_DETECTOR_PERF) || \ > > > + defined(CONFIG_X86_HARDLOCKUP_DETECTOR_HPET) > > > > Why not instead make CONFIG_X86_HARDLOCKUP_DETECTOR_HPET select > > CONFIG_HARDLOCKUP_DETECTOR_PERF? Keep the arch-specific details > > in the arch-specific files and all that. > > Thanks for your feedback, Paul! The HPET implementation does not use > perf. Thus, in my opinion is not correct for the HPET HLD to select > the perf implementation. Patch 8 of this series splits the perf-specific > code and the generic hardlockup detector code. Does this make sense?
That's what intermediate config symbols are for.
config HARDLOCKUP_DETECTOR_CORE bool
And make both PERF and HPET select it.
Thanks,
tglx
| |