| Date | Tue, 26 Mar 2019 22:00:24 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [RFC PATCH v2 02/14] x86/hpet: Expose more functions to read and write registers |
| |
On Wed, 27 Feb 2019, Ricardo Neri wrote: > struct irq_data; > @@ -109,6 +114,11 @@ extern void hpet_unregister_irq_handler(rtc_irq_handler handler); > static inline int hpet_enable(void) { return 0; } > static inline int is_hpet_enabled(void) { return 0; } > #define hpet_readl(a) 0 > +#define hpet_writel(d, a)
What for?
> +#ifdef CONFIG_X86_64 > +#define hpet_readq(a) 0 > +#define hpet_writeq(d, a) > +#endif
Ditto.
There are no users outside of HPET and your new HPET watchdog code for those. And both are not compiled when CONFIG_HPET=n.
The only reason to have the hpet_readl() define, which btw. should be an inline, is to avoid massive ifdeffery in the TSC calibration code.
Thanks,
tglx
|