Messages in this thread | | | Subject | Re: [PATCH 3/8] vfio/mdev: Removed unused kref | From | Kirti Wankhede <> | Date | Tue, 26 Mar 2019 00:11:01 +0530 |
| |
On 3/23/2019 4:50 AM, Parav Pandit wrote: > Remove unused kref from the mdev_device structure. > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver") > Signed-off-by: Parav Pandit <parav@mellanox.com> > --- > drivers/vfio/mdev/mdev_core.c | 1 - > drivers/vfio/mdev/mdev_private.h | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 4f213e4d..3d91f62 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -311,7 +311,6 @@ int mdev_device_create(struct kobject *kobj, struct device *dev, uuid_le uuid) > mutex_unlock(&mdev_list_lock); > > mdev->parent = parent; > - kref_init(&mdev->ref); > > mdev->dev.parent = dev; > mdev->dev.bus = &mdev_bus_type; > diff --git a/drivers/vfio/mdev/mdev_private.h b/drivers/vfio/mdev/mdev_private.h > index b5819b7..84b2b6c 100644 > --- a/drivers/vfio/mdev/mdev_private.h > +++ b/drivers/vfio/mdev/mdev_private.h > @@ -30,7 +30,6 @@ struct mdev_device { > struct mdev_parent *parent; > uuid_le uuid; > void *driver_data; > - struct kref ref; > struct list_head next; > struct kobject *type_kobj; > bool active; >
Yes, this should be removed.
Reviewed By: Kirti Wankhede <kwankhede@nvidia.com>
Thanks, Kirti
| |