lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 04/11] tracing: Use tracing error_log with trace event filters
On Mon, 25 Mar 2019 20:37:23 +0900
Namhyung Kim <namhyung@kernel.org> wrote:

> > /* Called after a '!' character but "!=" and "!~" are not "not"s */
> > static bool is_not(const char *str)
> > @@ -947,8 +948,10 @@ static void append_filter_err(struct filter_parse_error *pe,
> > if (pe->lasterr > 0) {
> > trace_seq_printf(s, "\n%*s", pos, "^");
> > trace_seq_printf(s, "\nparse_error: %s\n", err_text[pe->lasterr]);
> > + tracing_log_err("event filter parse error", filter->filter_string, err_text, pe->lasterr, pe->lasterr_pos);
> > } else {
> > trace_seq_printf(s, "\nError: (%d)\n", pe->lasterr);
> > + tracing_log_err("event filter parse error", filter->filter_string, err_text, FILT_ERR_ERRNO, 0);
>
> These lines are too long, could you please wrap?

Agreed.


> Otherwise, the whole series look good to me.
>
> Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks Namhyung!

-- Steve

\
 
 \ /
  Last update: 2019-03-25 15:29    [W:0.072 / U:1.656 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site