Messages in this thread | | | From | Ulf Hansson <> | Date | Mon, 25 Mar 2019 14:54:16 +0100 | Subject | Re: [PATCH v3 2/3] mmc: sdhci-of-arasan: Add DTS property to disable DCMDs. |
| |
On Mon, 25 Mar 2019 at 14:39, Christoph Müllner <christoph.muellner@theobroma-systems.com> wrote: > > > > On 25.03.2019, at 14:27, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > > > On Fri, 22 Mar 2019 at 12:39, Christoph Muellner > > <christoph.muellner@theobroma-systems.com> wrote: > >> > >> Direct commands (DCMDs) are an optional feature of eMMC 5.1's command > >> queue engine (CQE). The Arasan eMMC 5.1 controller uses the CQHCI, > >> which exposes a control register bit to enable the feature. > >> The current implementation sets this bit unconditionally. > >> > >> This patch allows to suppress the feature activation, > >> by specifying the property disable-cqe-dcmd. > >> > >> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com> > >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > >> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > > > > Applied for next, thanks! > > > > Perhaps both patch1 and patch2 should be tagged for stable? Then > > please tell me and I can add a tag. > > Hi Ulf, > > yes tagging for stable would be nice. > I guess, the following would fit: > > Fixes: 84362d79f436 ("mmc: sdhci-of-arasan: Add CQHCI support for arasan,sdhci-5.1") >
Great, I have added that to both of the commits and a stable tag. Thanks!
[...]
Kind regards Uffe
| |