lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 1/2] Bluetooth: hci_qca: Added support for WCN3998
From
Date
On 25/03/2019 12:31, Harish Bandi wrote:

> +bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
> +{
> + if ((soc_type == QCA_WCN3990) || (soc_type == QCA_WCN3998))
^ ^
spurious white-space here as well

> + return true;
> +
> + return false;
> +}

(Apologies for the bike-shed)

I don't know what the kernel coding-style says about this, but for
functions returning bool, isn't it better to write

return $BOOLEAN_EXPRESSION;

instead of

if ($BOOLEAN_EXPRESSION)
return true;
return false;

i.e.

bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
{
return soc_type == QCA_WCN3990 || soc_type == QCA_WCN3998;
}

Regards.

\
 
 \ /
  Last update: 2019-03-25 12:50    [W:0.043 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site