lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/8] mfd: axp20x: Add axp20x-led cell
On Fri, 15 Feb 2019, Stefan Mavrodiev wrote:

> Add axp20x-led cell for AXP20x, AXP221, AXP223, AXP228, AXP803, AXP809
> and AXP813.
>
> Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
> ---
> drivers/mfd/axp20x.c | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 3c97f2c0fdfe..e6ab078f0462 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -610,6 +610,9 @@ static const struct mfd_cell axp20x_cells[] = {
> .of_compatible = "x-powers,axp202-usb-power-supply",
> .num_resources = ARRAY_SIZE(axp20x_usb_power_supply_resources),
> .resources = axp20x_usb_power_supply_resources,
> + }, {
> + .name = "axp20x-led",
> + .of_compatible = "x-powers,axp20x-led",
> },
> };
>
> @@ -636,6 +639,9 @@ static const struct mfd_cell axp221_cells[] = {
> .of_compatible = "x-powers,axp221-usb-power-supply",
> .num_resources = ARRAY_SIZE(axp22x_usb_power_supply_resources),
> .resources = axp22x_usb_power_supply_resources,
> + }, {
> + .name = "axp20x-led",
> + .of_compatible = "x-powers,axp20x-led",
> },
> };
>
> @@ -662,6 +668,9 @@ static const struct mfd_cell axp223_cells[] = {
> .of_compatible = "x-powers,axp223-usb-power-supply",
> .num_resources = ARRAY_SIZE(axp22x_usb_power_supply_resources),
> .resources = axp22x_usb_power_supply_resources,
> + }, {
> + .name = "axp20x-led",
> + .of_compatible = "x-powers,axp20x-led",
> },
> };
>
> @@ -719,6 +728,9 @@ static const struct mfd_cell axp288_cells[] = {
> .resources = axp288_power_button_resources,
> }, {
> .name = "axp288_pmic_acpi",
> + }, {
> + .name = "axp20x-led",
> + .of_compatible = "x-powers,axp20x-led",
> },
> };
>
> @@ -741,8 +753,12 @@ static const struct mfd_cell axp803_cells[] = {
> .of_compatible = "x-powers,axp813-ac-power-supply",
> .num_resources = ARRAY_SIZE(axp20x_ac_power_supply_resources),
> .resources = axp20x_ac_power_supply_resources,
> + }, {
> + .name = "axp20x-regulator"
> + }, {
> + .name = "axp20x-led",
> + .of_compatible = "x-powers,axp20x-led",
> },
> - { .name = "axp20x-regulator" },

Nit: Please keep this at the bottom and as a one line entry.

Once fixed, please submit with my:

For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2019-03-25 11:02    [W:0.122 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site