Messages in this thread | | | Subject | Re: [PATCH 1/1] clk: meson: pll: fix rounding and setting a rate that matches precisely | From | Jerome Brunet <> | Date | Mon, 25 Mar 2019 10:48:35 +0100 |
| |
On Sun, 2019-03-24 at 17:43 +0100, Martin Blumenstingl wrote: > Make meson_clk_pll_is_better() consider a rate that precisely matches > the requested rate to be better than any previous rate (which was > smaller than the current). > > Prior to commit 8eed1db1adec6a ("clk: meson: pll: update driver for the > g12a") meson_clk_get_pll_settings() returned early (before calling > meson_clk_pll_is_better()) if the rate from the current iteration > matches the requested rate precisely. After this commit > meson_clk_pll_is_better() is called unconditionally. This requires > meson_clk_pll_is_better() to work with the case where "now == rate". > > This fixes a hang during boot on Meson8b / Odroid-C1 for me. > > Fixes: 8eed1db1adec6a ("clk: meson: pll: update driver for the g12a") > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Good catch !
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
| |