Messages in this thread | | | Date | Mon, 25 Mar 2019 09:34:13 +0100 | From | Daniel Vetter <> | Subject | Re: [PATCH] drm: vkms: check status of alloc_ordered_workqueue |
| |
On Fri, Mar 22, 2019 at 09:32:07PM -0500, Kangjie Lu wrote: > > > > On Mar 8, 2019, at 10:36 PM, Kangjie Lu <kjlu@umn.edu> wrote: > > > > alloc_ordered_workqueue may fail and return NULL. > > The fix returns ENOMEM when it fails to avoid potential NULL > > pointer dereference. > > > > Signed-off-by: Kangjie Lu <kjlu@umn.edu> > > --- > > drivers/gpu/drm/vkms/vkms_crtc.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c b/drivers/gpu/drm/vkms/vkms_crtc.c > > index 8a9aeb0a9ea8..bb66dbcd5e3f 100644 > > --- a/drivers/gpu/drm/vkms/vkms_crtc.c > > +++ b/drivers/gpu/drm/vkms/vkms_crtc.c > > @@ -219,6 +219,8 @@ int vkms_crtc_init(struct drm_device *dev, struct drm_crtc *crtc, > > spin_lock_init(&vkms_out->state_lock); > > > > vkms_out->crc_workq = alloc_ordered_workqueue("vkms_crc_workq", 0); > > + if (!vkms_out->crc_workq) > > + return -ENOMEM; > > Is this a reasonable patch?
lgtm, applied and thanks for your patch. -Daniel
> > > > > return ret; > > } > > -- > > 2.17.1 > > >
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |