lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v3] RISC-V: Always compile mm/init.c with cmodel=medany and notrace
On Mon, Mar 25, 2019 at 5:08 PM Christoph Hellwig <hch@infradead.org> wrote:
>
> > +ifdef CONFIG_FTRACE
> > +CFLAGS_REMOVE_init.o = -pg
> > +endif
> > +
> > obj-y += init.o
> > obj-y += fault.o
> > obj-y += extable.o
> > obj-y += ioremap.o
> > obj-y += cacheflush.o
> > +
> > +CFLAGS_init.o := -mcmodel=medany
>
> Can you keep the two flags adjustments togther, preferably towards
> the top of the file?

Sure, I will more the flags together.

>
> > +/*
> > + * The setup_vm() is called from head.S with MMU-off.
>
> s/The //g

Okay, I will update.

>
> Otherwis looks fine:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

Regards,
Anup

\
 
 \ /
  Last update: 2019-03-26 04:59    [W:0.037 / U:0.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site