lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [BACKPORT 4.4.y 04/25] USB: iowarrior: fix oops with malicious USB descriptors
    On Fri, Mar 22, 2019 at 04:43:55PM +0100, Arnd Bergmann wrote:
    > From: Josh Boyer <jwboyer@fedoraproject.org>
    >
    > The iowarrior driver expects at least one valid endpoint. If given
    > malicious descriptors that specify 0 for the number of endpoints,
    > it will crash in the probe function. Ensure there is at least
    > one endpoint on the interface before using it.
    >
    > The full report of this issue can be found here:
    > http://seclists.org/bugtraq/2016/Mar/87
    >
    > Reported-by: Ralf Spenneberg <ralf@spenneberg.net>
    > Cc: stable <stable@vger.kernel.org>
    > Signed-off-by: Josh Boyer <jwboyer@fedoraproject.org>
    > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    > (cherry picked from commit 4ec0ef3a82125efc36173062a50624550a900ae0)
    > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    > ---
    > drivers/usb/misc/iowarrior.c | 6 ++++++
    > 1 file changed, 6 insertions(+)

    This commit has been in the tree for a long time. It was in the 4.4.7
    release, back in April 2016. And then it was reverted in commit
    b7321e81fc36 ("USB: iowarrior: fix NULL-deref at probe") as it broke
    systems. So why add it back, the correct functionality should be there
    today, right?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2019-03-26 02:24    [W:2.818 / U:0.120 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site