lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip
On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote:
> > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG))
> > + return;
>
> Can all of these debugfs functions be wrapped with an #if ... #endif such
> that, if CONFIG_EDAC_DEBUG is not set, they will all be stripped out by
> the preprocessor?

Why would you make the code more ugly with ifdeffery?

Do you have any serious code size constraints so that you absolutely
need to remove a couple of KBs?

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

\
 
 \ /
  Last update: 2019-03-25 07:58    [W:0.092 / U:0.512 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site