Messages in this thread | | | Date | Mon, 25 Mar 2019 07:57:37 +0100 | From | Borislav Petkov <> | Subject | Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip |
| |
On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote: > > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG)) > > + return; > > Can all of these debugfs functions be wrapped with an #if ... #endif such > that, if CONFIG_EDAC_DEBUG is not set, they will all be stripped out by > the preprocessor?
Why would you make the code more ugly with ifdeffery?
Do you have any serious code size constraints so that you absolutely need to remove a couple of KBs?
-- Regards/Gruss, Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
| |