Messages in this thread | | | From | Linus Torvalds <> | Date | Mon, 25 Mar 2019 14:48:50 -0700 | Subject | Re: [PATCH] parport: daisy: do not try to load lowlevel driver |
| |
On Mon, Mar 25, 2019 at 2:13 PM Sudip Mukherjee <sudipm.mukherjee@gmail.com> wrote: > > We do not need to search for ports and bind the initial list of ports > to daisy driver as daisy driver is always the first driver to use the > new found parport and we know when the parport bus is registering the > list of parport will always be empty. So, proceed with the daisy_drv > registration even if the list of parport is empty.
This is completely hacky and senseless.
The problem as far as I can tell is that the daisy driver shouldn't register early at all, and shouldn't be a subsys initcall. It should just be a driver initcall, and happen naturally after the parport subsystem has been initialized.
This patch just makes the code even *less* understandable.
I'm going to revert that problematic commit.
If you can get it working without that incorrect and senseless tie-in of the daisy driver registration with the regular partport init sequence, we can revisit this.
Linus
| |