Messages in this thread | | | Date | Mon, 25 Mar 2019 10:53:53 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible |
| |
On Sat, 23 Mar 2019 07:35:18 -0700 Andi Kleen <ak@linux.intel.com> wrote:
> On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote: > > On Thu, 21 Mar 2019 15:00:03 -0700 > > Andi Kleen <andi@firstfloor.org> wrote: > > > > > From: Andi Kleen <ak@linux.intel.com> > > > > > > This function is referenced from assembler, so in LTO > > > it needs to be global and visible to not be optimized away. > > > > > > > I got it. > > > > Acked-by: Masami Hiramatsu <mhiramat@kernel.org> > > > > Andi, out of curiousity, that is not only for x86, but > > does all arch have to care it? > > Yes all architectures need it for LTO, but I currently > only test x86. There are some other people who made it work > on ARM / MIPS / PowerPC before.
That's good to know! I worried that similar mistake I made on another arch :)
Thank you,
> > -Andi
-- Masami Hiramatsu <mhiramat@kernel.org>
| |