Messages in this thread Patch in this message | | | Date | Sun, 24 Mar 2019 17:33:45 +0100 | From | Sicilia Cristian <> | Subject | Re: [PATCH v2 2/5] staging: iio: adc: Converted bool to bitfield format |
| |
On Sun, Mar 24, 2019 at 12:34:52PM +0000, Jonathan Cameron wrote: > On Sat, 23 Mar 2019 20:21:39 +0100 > Cristian Sicilia <sicilia.cristian@gmail.com> wrote: > > > Changed bool format to bitfield format to save space. > > > > Signed-off-by: Cristian Sicilia <sicilia.cristian@gmail.com> > > > > --- > > The strange thing is that this struct seems not populated > > using a DTS binding function. > Indeed and that should have definitely been a warning sign ;) > We are looking at traditional platform data here (pre device > tree) and generally we will want to drop it entirely for old > drivers that we are looking to move out of staging. > > I don't mind improving it prior to dropping (as it avoids > setting bad precedence in the code base in the meantime) but > one comment inline... >
Thanks for comment
> > --- > > drivers/staging/iio/adc/ad7192.h | 16 ++++++++-------- > > 1 file changed, 8 insertions(+), 8 deletions(-) > > > > diff --git a/drivers/staging/iio/adc/ad7192.h b/drivers/staging/iio/adc/ad7192.h > > index 7433a43..87891ba 100644 > > --- a/drivers/staging/iio/adc/ad7192.h > > +++ b/drivers/staging/iio/adc/ad7192.h > > @@ -35,13 +35,13 @@ struct ad7192_platform_data { > > u16 vref_mv; > > u8 clock_source_sel; > > u32 ext_clk_hz; > > - bool refin2_en; > > - bool rej60_en; > > - bool sinc3_en; > > - bool chop_en; > > - bool buf_en; > > - bool unipolar_en; > > - bool burnout_curr_en; > > -}; > > + u8 refin2_en:1; > > + u8 rej60_en:1; > > + u8 sinc3_en:1; > > + u8 chop_en:1; > > + u8 buf_en:1; > > + u8 unipolar_en:1; > > + u8 burnout_curr_en:1; > > +} __attribute__((__packed__)); > Please don't use packed for anything without a very very good reason. > it may result in data layouts that are much harder to read from. > That obviously doesn't matter here as I doubt it's read in a fast path.
Ok, I remove it, thanks
> > > > > #endif /* IIO_ADC_AD7192_H_ */ >
| |